spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GraceH <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...
Date Tue, 04 Aug 2015 01:09:22 GMT
Github user GraceH commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7888#discussion_r36149140
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
    @@ -413,25 +413,38 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl,
val rpcEnv: Rp
        *
        * @param executorIds identifiers of executors to kill
        * @param replace whether to replace the killed executors with new ones
    +   * @param force whether to kill busy executors (who are running tasks)
        * @return whether the kill request is acknowledged.
        */
    -  final def killExecutors(executorIds: Seq[String], replace: Boolean): Boolean = synchronized
{
    +  final def killExecutors(executorIds: Seq[String],
    +                          replace: Boolean,
    +                          force: Boolean): Boolean = synchronized {
    --- End diff --
    
    Thanks. I will fix that. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message