spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9112] [ML] Implement Stats for Logistic...
Date Mon, 03 Aug 2015 23:28:06 GMT
Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/7538#issuecomment-127430728
  
    @MechCoder Thanks for the updates!  We'll need to use traits to fix the multiple inheritance
issue:
    ```
    sealed trait LogisticRegressionSummary
    sealed trait LogisticRegressionTrainingSummary
    class BinaryLogisticRegressionSummary extends LogisticRegressionSummary
    class BinaryLogisticRegressionTrainingSummary extends BinaryLogisticRegressionSummary
with LogisticRegressionTrainingSummary
    ```
    Notes:
    * LogisticRegressionSummary could be an abstract class if it saves a lot of code, but
if not, I'd prefer it remain a trait.
    * I'm marking the traits sealed so that we can extend them in the future without breaking
the public API.
    * These classes and traits will need to be public.
    
    Let me know if you have alternate ideas for these items.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message