spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EntilZha <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8231][SQL] Add array_contains
Date Mon, 03 Aug 2015 05:04:11 GMT
Github user EntilZha commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7580#discussion_r36056386
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
    @@ -35,3 +37,62 @@ case class Size(child: Expression) extends UnaryExpression with ExpectsInputType
         nullSafeCodeGen(ctx, ev, c => s"${ev.primitive} = ($c).size();")
       }
     }
    +
    +case class ArrayContains(left: Expression, right: Expression)
    +  extends BinaryExpression with ExpectsInputTypes {
    +
    +  override def dataType: DataType = BooleanType
    +
    +  override def inputTypes: Seq[AbstractDataType] = right.dataType match {
    +    case NullType => Seq()
    +    case _ => left.dataType match {
    +      case n @ ArrayType(element, _) => Seq(n, element)
    +      case _ => Seq()
    +    }
    +  }
    +
    +  override def checkInputDataTypes(): TypeCheckResult = {
    +    inputTypes.size match {
    +      case 0 => TypeCheckResult.TypeCheckFailure("Null typed values cannot be used
as arguments")
    +      case _ => super.checkInputDataTypes()
    +    }
    +  }
    +
    +  override def nullable: Boolean = false
    +
    +  override def eval(input: InternalRow): Boolean = {
    +    val arr = left.eval(input)
    +    if (arr == null) {
    +      false
    +    } else {
    +      val value = right.eval(input)
    +      if (value == null) {
    +        false
    +      } else {
    +        arr.asInstanceOf[Seq[Any]].contains(value)
    --- End diff --
    
    Not sure I understand the comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message