spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8735] [SQL] Expose memory usage for shu...
Date Mon, 03 Aug 2015 02:14:29 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/7770#issuecomment-127099644
  
    
    
    
    
    Review status: 49 of 51 files reviewed at latest revision, 12 unresolved discussions,
all commit checks successful.
    
    ---
    
    <sup>**[core/src/test/scala/org/apache/spark/AccumulatorSuite.scala, line 275 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvlEDWoM1qKnCpUfRLP)**
([raw file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/core/src/test/scala/org/apache/spark/AccumulatorSuite.scala#L275)):</sup>
    Done.
    
    ---
    
    <sup>**[core/src/test/scala/org/apache/spark/ui/StagePageSuite.scala, line 53 \[r13\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvkmpXznXanlsxkO4pa)**
([raw file](https://github.com/apache/spark/blob/a87b4d0e06e407444b746619e1dde96ae0bc4daa/core/src/test/scala/org/apache/spark/ui/StagePageSuite.scala#L53)):</sup>
    Done.
    
    ---
    
    <sup>**[core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala,
line 408 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvl5D7f5rgRjCB303Iq)**
([raw file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala#L408)):</sup>
    Ok, later
    
    ---
    
    <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala,
line 306 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvl6qWYX_EY-T3clcvi)**
([raw file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala#L306)):</sup>
    Done.
    
    ---
    
    <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala,
line 78 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvl8u8dGfGCUytrYyfN)**
([raw file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala#L78)):</sup>
    ok, we'll do that outside this patch
    
    ---
    
    <sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/sort.scala, line
81 \[r1\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvVHinQX4wFdRHT7yOV-r1-83)**
([raw file](https://github.com/apache/spark/blob/5b5e6f36b8a0e37f1953e12c438e01c58872e5fa/sql/core/src/main/scala/org/apache/spark/sql/execution/sort.scala#L81)):</sup>
    ok, we'll do that outside this patch
    
    ---
    
    <sup>**[sql/core/src/test/scala/org/apache/spark/sql/BroadcastJoinSuite.scala, line
18 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvlAdjyYunIYwbkUn9y)** ([raw
file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/sql/core/src/test/scala/org/apache/spark/sql/BroadcastJoinSuite.scala#L18)):</sup>
    ah ok
    
    ---
    
    <sup>**[sql/core/src/test/scala/org/apache/spark/sql/BroadcastJoinSuite.scala, line
49 \[r16\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvlBEPnOWNFyn4RzkCF)** ([raw
file](https://github.com/apache/spark/blob/c00a197a2f78844f4f18e52364d55116cb0a374a/sql/core/src/test/scala/org/apache/spark/sql/BroadcastJoinSuite.scala#L49)):</sup>
    OK, if it doesn't pass already then it has to be a blocker. Otherwise let's leave it till
later.
    
    ---
    
    
    Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7770)
    <!-- Sent from Reviewable.io -->



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message