spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9136][SQL] fix several bugs in DateTime...
Date Fri, 17 Jul 2015 16:09:03 GMT
GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/7473

    [SPARK-9136][SQL] fix several bugs in DateTimeUtils.stringToTimestamp

    a follow up of https://github.com/apache/spark/pull/7353
    
    1. we should use `Calendar.HOUR_OF_DAY` instead of `Calendar.HOUR`(this is for AM, PM).
    2. we should call `c.set(Calendar.MILLISECOND, 0)` after `Calendar.getInstance`
    
    I'm not sure why the tests didn't fail in jenkins, but I ran latest spark master branch
locally and `DateTimeUtilsSuite` failed. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark datetime

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7473
    
----
commit ddf67ad0a8a088efe8cbb358f3f6ac6351c441ff
Author: Wenchen Fan <cloud0fan@outlook.com>
Date:   2015-07-17T16:02:02Z

    fix several bugs in DateTimeUtils.stringToTimestamp

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message