spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8959] [SQL] [HOTFIX] Removes parquet-th...
Date Thu, 09 Jul 2015 19:42:44 GMT
GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/7330

    [SPARK-8959] [SQL] [HOTFIX] Removes parquet-thrift and libthrift dependencies

    These two dependencies were introduced in #7231 to help testing Parquet compatibility
with `parquet-thrift`. However, they somehow crash the Scala compiler in Maven build and SBT
Scala 2.11 build.
    
    This PR fixes this issue by:
    
    1. Removing these two dependencies, and
    2. Instead of generating the testing Parquet file programmatically, checking in an actual
testing Parquet file generated by `parquet-thrift` as a test resource.
    
    This is just a quick fix to bring back Maven and SBT Scala 2.11 builds. Need to figure
out the root case as binary Parquet files are harder to maintain.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark spark-8959

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7330
    
----
commit 2492f0c508d81c43c195094174baea7215c38ac2
Author: Cheng Lian <lian@databricks.com>
Date:   2015-07-09T19:37:25Z

    Brings back Maven and SBT Scala 2.11 builds

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message