spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8770][SQL] Create BinaryOperator abstra...
Date Wed, 01 Jul 2015 22:27:31 GMT
GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/7170

    [SPARK-8770][SQL] Create BinaryOperator abstract class.

    Our current BinaryExpression abstract class is not for generic binary expressions, i.e.
it requires left/right children to have the same type. However, due to its name, contributors
build new binary expressions that don't have that assumption (e.g. Sha) and still extend BinaryExpression.
    
    This patch creates a new BinaryOperator abstract class, and update the analyzer o only
apply type casting rule there. This patch also adds the notion of "prettyName" to expressions,
which defines the user-facing name for the expression.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark binaryoperator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7170
    
----
commit 51264a50398144d795f050235685b6779a11e465
Author: Reynold Xin <rxin@databricks.com>
Date:   2015-07-01T22:24:56Z

    [SPARK-8770][SQL] Create BinaryOperator abstract class.
    
    Our current BinaryExpression abstract class is not for generic binary expressions, i.e.
it requires left/right children to have the same type. However, due to its name, contributors
build new binary expressions that don't have that assumption (e.g. Sha) and still extend BinaryExpression.
    
    This patch creates a new BinaryOperator abstract class, and update the analyzer o only
apply type casting rule there.
    
    This patch also adds the notion of "prettyName" to expressions, which defines the user-facing
name for the expression.
    
    /Users/rxin/Desktop/status-match

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message