spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9463] [ML] Expose model coefficients wi...
Date Thu, 30 Jul 2015 22:27:41 GMT
Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7771#discussion_r35928666
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -71,3 +71,27 @@ setMethod("predict", signature(object = "PipelineModel"),
               function(object, newData) {
                 return(dataFrame(callJMethod(object@model, "transform", newData@sdf)))
               })
    +
    +#' Get statistics on a model.
    +#'
    +#' Returns statistics on a model produced by glm(), similarly to R's summary().
    +#'
    +#' @param model A fitted MLlib model
    +#' @return data.frame containing model statistics
    +#' @rdname glm
    +#' @export
    +#' @examples
    +#'\dontrun{
    +#' model <- glm(y ~ x, trainingData)
    +#' summary(model)
    +#'}
    +setMethod("summary", signature(object = "PipelineModel"),
    --- End diff --
    
    That one is specific to summary.glm class, I think we need to override summary to have
it work for pipelinemodel.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message