spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8735] [WIP] [SQL] Expose memory usage f...
Date Thu, 30 Jul 2015 19:00:38 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7770#discussion_r35907224
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
    @@ -126,7 +131,11 @@ class ExternalAppendOnlyMap[K, V, C](
     
         while (entries.hasNext) {
           curEntry = entries.next()
    -      if (maybeSpill(currentMap, currentMap.estimateSize())) {
    +      val estimatedSize = currentMap.estimateSize()
    --- End diff --
    
    Won't this be really expensive? It looks like this will try to re-estimate the map's size
on each insertion. Does the map make optimizations so that this is cheap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message