spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9469][SQL] TungstenSort should not do c...
Date Thu, 30 Jul 2015 05:40:33 GMT
GitHub user rxin reopened a pull request:

    https://github.com/apache/spark/pull/7781

    [SPARK-9469][SQL] TungstenSort should not do conversion itself

    TungstenSort assumes input rows are safe rows, and uses a projection to turn the safe
rows into UnsafeRows. This patch takes that part of the logic out of TungstenSort, and move
it into the planner. If input rows are already UnsafeRows (e.g. coming out of a TungstenProject),
no conversion is needed at all.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-9469

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7781
    
----
commit 9b1c3bd605d40397416fe1f9b748c5a0b16c9fb8
Author: Reynold Xin <rxin@databricks.com>
Date:   2015-07-30T05:39:13Z

    [SPARK-9469][SQL] TungstenSort should not do safe -> unsafe conversion itself.
    
    TungstenSort itself assumes input rows are safe rows, and uses a projection to turn the
safe rows into UnsafeRows. We should take that part of the logic out of TungstenSort, and
let the planner take care of the conversion. In that case, if the input is UnsafeRow already,
no conversion is needed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message