spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <>
Subject [GitHub] spark pull request: [SPARK-9428][SQL] Add test cases for null inpu...
Date Thu, 30 Jul 2015 05:12:18 GMT
Github user davies commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
    @@ -1035,7 +1034,11 @@ case class RegExpReplace(subject: Expression, regexp: Expression,
rep: Expressio
                 ${ev.primitive} = ${classNameUTF8String}.fromString(${termResult}.toString());
                 ${ev.isNull} = false;
    +          } else {
    +            ${ev.isNull} = true;
    --- End diff --
    For UnaryExpression, it's better to use `ev.isNull = eval.isNull`, for others, using `ev.isNull
= true` will be better.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message