spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Date Wed, 29 Jul 2015 20:53:53 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/7750#issuecomment-126093097
  
    Does the `val size = math.min(s1, s2)` line need `toLong` too? it gets multiplied by a
big number before being divided by one. I could be missing why it's not needed or can't be
done but seemed like a possible issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message