spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhichao-li <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...
Date Wed, 29 Jul 2015 08:56:07 GMT
Github user zhichao-li commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6638#discussion_r35739540
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
---
    @@ -75,49 +53,4 @@ class ScriptTransformationSuite extends SparkPlanTest {
           )(TestHive),
           rowsDf.collect())
       }
    -
    -  test("script transformation should not swallow errors from upstream operators (no serde)")
{
    -    val rowsDf = Seq("a", "b", "c").map(Tuple1.apply).toDF("a")
    -    val e = intercept[TestFailedException] {
    -      checkAnswer(
    -        rowsDf,
    -        (child: SparkPlan) => new ScriptTransformation(
    -          input = Seq(rowsDf.col("a").expr),
    -          script = "cat",
    -          output = Seq(AttributeReference("a", StringType)()),
    -          child = ExceptionInjectingOperator(child),
    -          ioschema = noSerdeIOSchema
    -        )(TestHive),
    -        rowsDf.collect())
    -    }
    -    assert(e.getMessage().contains("intentional exception"))
    -  }
    -
    -  test("script transformation should not swallow errors from upstream operators (with
serde)") {
    --- End diff --
    
    Maybe I need to add this back, but seems like if the `child` throw exception, then the
actual result should be null which would cause `checkAnswer` throw not equal exception first
instead of "intentional exception"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message