spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-6793][MLlib] OnlineLDAOptimizer LDA per...
Date Wed, 29 Jul 2015 04:01:15 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7705#discussion_r35726187
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
    @@ -197,8 +238,86 @@ class LocalLDAModel private[clustering] (
       // TODO:
       // override def topicDistributions(documents: RDD[(Long, Vector)]): RDD[(Long, Vector)]
= ???
     
    +  /**
    +   * Calculate and return per-word likelihood bound, using the `batch` of
    +   * documents as evaluation corpus.
    +   */
    +  // TODO: calcualte logPerplexity over training set online during training, reusing
gammad instead
    +  // of performing variational inference again in [[bound()]]
    +  def logPerplexity(
    +      batch: RDD[(Long, Vector)],
    --- End diff --
    
    I'd prefer this be called "documents" to match LDA.run().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message