spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-8064, build against Hive 1.2.1
Date Tue, 28 Jul 2015 21:46:44 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7191#discussion_r35705531
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -515,16 +530,18 @@ class HiveContext(sc: SparkContext) extends SQLContext(sc) with
Logging {
     
     private[hive] object HiveContext {
       /** The version of hive used internally by Spark SQL. */
    -  val hiveExecutionVersion: String = "0.13.1"
    +  val hiveExecutionVersion: String = "1.2.1"
     
       val HIVE_METASTORE_VERSION: String = "spark.sql.hive.metastore.version"
       val HIVE_METASTORE_JARS = stringConf("spark.sql.hive.metastore.jars",
         defaultValue = Some("builtin"),
    -    doc = "Location of the jars that should be used to instantiate the HiveMetastoreClient.
This" +
    -      " property can be one of three options: " +
    -      "1. \"builtin\" Use Hive 0.13.1, which is bundled with the Spark assembly jar when
" +
    -      "<code>-Phive</code> is enabled. When this option is chosen, " +
    -      "spark.sql.hive.metastore.version must be either <code>0.13.1</code>
or not defined. " +
    +    doc = s"Location of the jars that should be used to instantiate the HiveMetastoreClient.
This" +
    +      s" property can be one of three options: " +
    +      "1. \"builtin\"" +
    +       s" Use Hive ${hiveExecutionVersion}, which is bundled with the Spark assembly
jar when " +
    +      s"<code>-Phive</code> is enabled. When this option is chosen, " +
    +      s"spark.sql.hive.metastore.version must be either <code>${hiveExecutionVersion}</code>"
+
    +        s" or not defined. " +
    --- End diff --
    
    nit: can you reformat this?  maybe even use `.stripMargin`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message