spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2352] [ML] Add Artificial Neural Networ...
Date Tue, 28 Jul 2015 19:25:11 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7621#discussion_r35689329
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/MultilayerPerceptronRegressor.scala
---
    @@ -0,0 +1,206 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.regression
    +
    +import breeze.linalg.{argmax => Bargmax}
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.annotation.Experimental
    +import org.apache.spark.ml.{Model, Transformer, Estimator, PredictorParams}
    +import org.apache.spark.ml.param._
    +import org.apache.spark.ml.param.shared._
    +import org.apache.spark.ml.util.Identifiable
    +import org.apache.spark.mllib.ann.{FeedForwardTopology, FeedForwardTrainer}
    +import org.apache.spark.mllib.linalg.{VectorUDT, Vector}
    +import org.apache.spark.sql.{Row, DataFrame}
    +import org.apache.spark.sql.functions._
    +import org.apache.spark.sql.types.{StructField, StructType}
    +
    +/**
    + * Params for Multilayer Perceptron.
    + */
    +private[ml] trait MultilayerPerceptronParams extends PredictorParams
    +with HasSeed with HasMaxIter with HasTol {
    +  /**
    +   * Layer sizes including input size and output size.
    +   * @group param
    +   */
    +  final val layers: IntArrayParam =
    +    // TODO: we need IntegerArrayParam!
    +    new IntArrayParam(this, "layers",
    +      "Sizes of layers including input and output from bottom to the top." +
    --- End diff --
    
    I'm not sure whether `bottom` and `top` are standard terms. `Sizes of layers from input
layer to output layer` looks sufficient to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message