spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9393] [SQL] Fix several error-handling ...
Date Tue, 28 Jul 2015 08:15:42 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7710#discussion_r35623734
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -874,15 +874,15 @@ https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
                 }
     
                 def matchSerDe(clause: Seq[ASTNode])
    -              : (Seq[(String, String)], String, Seq[(String, String)]) = clause match
{
    +              : (Seq[(String, String)], Option[String], Seq[(String, String)]) = clause
match {
                   case Token("TOK_SERDEPROPS", propsClause) :: Nil =>
                     val rowFormat = propsClause.map {
                       case Token(name, Token(value, Nil) :: Nil) => (name, value)
                     }
    -                (rowFormat, "", Nil)
    +                (rowFormat, None, Nil)
     
                   case Token("TOK_SERDENAME", Token(serdeClass, Nil) :: Nil) :: Nil =>
    -                (Nil, serdeClass, Nil)
    +                (Nil, Some(PlanUtils.stripQuotes(serdeClass)), Nil)
    --- End diff --
    
    Which one is better? `BaseSemanticAnalyzer.unescapeSQLString` or `PlanUtils.stripQuotes`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message