spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8195] [SPARK-8196] [SQL] udf next_day l...
Date Tue, 28 Jul 2015 05:06:21 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6986#discussion_r35614426
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
    @@ -184,4 +184,26 @@ class DateFunctionsSuite extends QueryTest {
           Row(15, 15, 15))
       }
     
    +  test("function last_day") {
    +    val df1 = Seq((1, "2015-07-23"), (2, "2015-07-24")).toDF("i", "d")
    +    val df2 = Seq((1, "2015-07-23 00:11:22"), (2, "2015-07-24 11:22:33")).toDF("i", "t")
    +    checkAnswer(
    +      df1.select(last_day(col("d"))),
    +      Seq(Row(Date.valueOf("2015-07-31")), Row(Date.valueOf("2015-07-31"))))
    +    checkAnswer(
    +      df2.select(last_day(col("t"))),
    +      Seq(Row(Date.valueOf("2015-07-31")), Row(Date.valueOf("2015-07-31"))))
    +  }
    +
    +  test("function next_day") {
    +    val df1 = Seq(("mon", "2015-07-23"), ("tuesday", "2015-07-20")).toDF("dow", "d")
    +    val df2 = Seq(("th", "2015-07-23 00:11:22"), ("xx", "2015-07-24 11:22:33")).toDF("dow",
"t")
    +    checkAnswer(
    +      df1.select(next_day(col("d"), "MONDAY")),
    +      Seq(Row(Date.valueOf("2015-07-27")), Row(Date.valueOf("2015-07-27"))))
    +    checkAnswer(
    +      df2.select(next_day(col("t"), "th")),
    +      Seq(Row(Date.valueOf("2015-07-30")), Row(null)))
    --- End diff --
    
    note that this actually fails unit tests. I thought it passed but it was from a previous
commit.
    
    Can you please pay a little bit more attention in the future and at least run your own
unit tests locally? Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message