spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8195] [SPARK-8196] [SQL] udf next_day l...
Date Tue, 28 Jul 2015 02:07:17 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6986#discussion_r35608548
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2392,6 +2399,16 @@ object functions {
       def minute(columnName: String): Column = minute(Column(columnName))
     
       /**
    +   * Returns the first date which is later than given date sd and named as dow.
    +   * For example, next_day('2015-07-27', 'Sunday') would return 2015-08-02, which is
the
    +   * first Sunday later than 2015-07-27. The parameter dayOfWeek could be 2-letter, 3-letter,
    +   * or full name of the day of the week (e.g. Mo, tue, FRIDAY).
    +   * @group datetime_funcs
    +   * @since 1.5.0
    +   */
    +  def next_day(sd: Column, dayOfWeek: Column): Column = NextDay(sd.expr, dayOfWeek.expr)
    --- End diff --
    
    i think it is ok to not support that in the data frame api, since it is very unlikely
somebody will be using a non literal.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message