spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <>
Subject [GitHub] spark pull request: [SPARK-9170][SQL] Instead of StandardStructObj...
Date Fri, 24 Jul 2015 06:42:05 GMT
Github user viirya commented on a diff in the pull request:
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala ---
    @@ -86,19 +86,10 @@ private[orc] class OrcOutputWriter(
    -    TypeInfoUtils
    -      .getStandardJavaObjectInspectorFromTypeInfo(typeInfo)
    -      .asInstanceOf[StructObjectInspector]
    +    OrcStruct.createObjectInspector(typeInfo.asInstanceOf[StructTypeInfo])
    +      .asInstanceOf[SettableStructObjectInspector]
    --- End diff --
    `OrcStruct.createObjectInspector ` will return a `OrcStructInspector` for STRUCT data
type. It is a `SettableStructObjectInspector`. Because we pass a `StructTypeInfo` when calling
`createObjectInspector`, I think it should be safe.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message