spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8882][Streaming]Add a new Receiver sche...
Date Fri, 24 Jul 2015 03:43:24 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7276#discussion_r35393643
  
    --- Diff: streaming/src/test/scala/org/apache/spark/streaming/scheduler/ReceiverSchedulingPolicySuite.scala
---
    @@ -0,0 +1,130 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming.scheduler
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.SparkFunSuite
    +
    +class ReceiverSchedulingPolicySuite extends SparkFunSuite {
    +
    +  val receiverSchedulingPolicy = new ReceiverSchedulingPolicy
    +
    +  test("rescheduleReceiver: empty executors") {
    +    val scheduledExecutors =
    +      receiverSchedulingPolicy.rescheduleReceiver(0, None, Map.empty, executors = Seq.empty)
    +    assert(scheduledExecutors === Seq.empty)
    +  }
    +
    +  test("rescheduleReceiver: receiver preferredLocation") {
    +    val receiverTrackingInfoMap = Map(
    +      0 -> ReceiverTrackingInfo(0, ReceiverState.INACTIVE, None, None))
    +    val scheduledExecutors = receiverSchedulingPolicy.rescheduleReceiver(
    +      0, Some("host1"), receiverTrackingInfoMap, executors = Seq("host2"))
    +    assert(scheduledExecutors.toSet === Set("host1", "host2"))
    +  }
    +
    +  test("rescheduleReceiver: return all idle executors if more than 3 idle executors")
{
    +    val executors = Seq("host1", "host2", "host3", "host4", "host5")
    +    // host3 is idle
    +    val receiverTrackingInfoMap = Map(
    +      0 -> ReceiverTrackingInfo(0, ReceiverState.ACTIVE, None, Some("host1")))
    +    val scheduledExecutors = receiverSchedulingPolicy.rescheduleReceiver(
    +      1, None, receiverTrackingInfoMap, executors)
    +    assert(scheduledExecutors.toSet === Set("host2", "host3", "host4", "host5"))
    +  }
    +
    +  test("rescheduleReceiver: return 3 best options if less than 3 idle executors") {
    +    val executors = Seq("host1", "host2", "host3", "host4", "host5")
    +    // Weights: host1 = 1.5, host2 = 0.5, host3 = 1.0
    +    // host4 and host5 are idle
    +    val receiverTrackingInfoMap = Map(
    +      0 -> ReceiverTrackingInfo(0, ReceiverState.ACTIVE, None, Some("host1")),
    +      1 -> ReceiverTrackingInfo(1, ReceiverState.SCHEDULED, Some(Seq("host2", "host3")),
None),
    +      2 -> ReceiverTrackingInfo(1, ReceiverState.SCHEDULED, Some(Seq("host1", "host3")),
None))
    +    val scheduledExecutors = receiverSchedulingPolicy.rescheduleReceiver(
    +      3, None, receiverTrackingInfoMap, executors)
    +    assert(scheduledExecutors.toSet === Set("host2", "host4", "host5"))
    +  }
    +
    +  test("scheduleReceivers: " +
    +    "schedule receivers evenly when there are more receivers than executors") {
    +    val receivers = (0 until 6).map(new DummyReceiver(_))
    +    val executors = (10000 until 10003).map(port => s"localhost:${port}")
    +    val scheduledExecutors = receiverSchedulingPolicy.scheduleReceivers(receivers, executors)
    +    val numReceiversOnExecutor = mutable.HashMap[String, Int]()
    +    // There should be 2 receivers running on each executor and each receiver has one
executor
    +    scheduledExecutors.foreach { case (receiverId, executors) =>
    +      assert(executors.size == 1)
    +      numReceiversOnExecutor(executors(0)) = numReceiversOnExecutor.getOrElse(executors(0),
0) + 1
    +    }
    +    assert(numReceiversOnExecutor === executors.map(_ -> 2).toMap)
    +  }
    +
    +
    +  test("scheduleReceivers: " +
    +    "schedule receivers evenly when there are more executors than receivers") {
    +    val receivers = (0 until 3).map(new DummyReceiver(_))
    +    val executors = (10000 until 10006).map(port => s"localhost:${port}")
    +    val scheduledExecutors = receiverSchedulingPolicy.scheduleReceivers(receivers, executors)
    +    val numReceiversOnExecutor = mutable.HashMap[String, Int]()
    +    // There should be 1 receiver running on each executor and each receiver has two
executors
    +    scheduledExecutors.foreach { case (receiverId, executors) =>
    +      assert(executors.size == 2)
    +      executors.foreach { l =>
    +        numReceiversOnExecutor(l) = numReceiversOnExecutor.getOrElse(l, 0) + 1
    +      }
    +    }
    +    assert(numReceiversOnExecutor === executors.map(_ -> 1).toMap)
    +  }
    +
    +  test("scheduleReceivers: schedule receivers evenly when the preferredLocations are
even") {
    --- End diff --
    
    Got it, makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message