spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9251][SPARK-9083][SQL] do not order by ...
Date Thu, 23 Jul 2015 16:45:25 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7593#discussion_r35343071
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -77,6 +77,7 @@ class Analyzer(
           ExtractWindowExpressions ::
           GlobalAggregates ::
           UnresolvedHavingClauseAttributes ::
    +      RemoveEvaluationFromSort ::
    --- End diff --
    
    The origin motivation is adding a project to materialize nondeterministic expressions
in ORDER BY to avoid extra evaluation that lead to wrong answer, see [JIRA](https://issues.apache.org/jira/browse/SPARK-9083).
In an offline discussion we decided to apply this rule for all still-need-evaluate expressions.
But now I think it maybe overkill. @rxin  What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message