spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MechCoder <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6485] [MLlib] [Python] Add CoordinateMa...
Date Wed, 22 Jul 2015 17:47:43 GMT
Github user MechCoder commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7554#discussion_r35241707
  
    --- Diff: python/pyspark/mllib/linalg.py ---
    @@ -1152,9 +1156,385 @@ def sparse(numRows, numCols, colPtrs, rowIndices, values):
             return SparseMatrix(numRows, numCols, colPtrs, rowIndices, values)
     
     
    +class DistributedMatrix(object):
    +    """Represents a distributively stored matrix backed by one or more RDDs."""
    +    def numRows(self):
    +        """Get or compute the number of rows."""
    +        raise NotImplementedError
    +
    +    def numCols(self):
    +        """Get or compute the number of cols."""
    +        raise NotImplementedError
    +
    +
    +class DistributedMatrices(object):
    +    """Factory methods for distributed matrices."""
    +    @staticmethod
    +    def rowMatrix(rows, numRows=0, numCols=0):
    +        """
    +        Create a RowMatrix.
    +
    +        :param rows: An RDD of Vectors.
    +        """
    +        javaRowMatrix = callMLlibFunc("createRowMatrix", rows, long(numRows), int(numCols))
    --- End diff --
    
    nitpick: You might want to check if rows is a RDD.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message