spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8176] [SPARK-8197] [SQL] function to_da...
Date Wed, 22 Jul 2015 06:38:13 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6988#discussion_r35185201
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
    @@ -258,3 +258,70 @@ case class DateFormatClass(left: Expression, right: Expression) extends
BinaryEx
         })
       }
     }
    +
    +/**
    + * Returns the date part of a timestamp string.
    + */
    +case class ToDate(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
{
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(DateType)
    +
    +  override def dataType: DataType = DateType
    +
    +  override def eval(input: InternalRow): Any = {
    +    child.eval(input).asInstanceOf[Int]
    +  }
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {
    +    nullSafeCodeGen(ctx, ev, (time) => {
    +      time
    +    })
    +  }
    +}
    +
    +/**
    + * Returns date truncated to the unit specified by the format.
    + */
    +case class Trunc(date: Expression, format: Expression)
    +  extends BinaryExpression with ImplicitCastInputTypes {
    +  override def left: Expression = date
    +  override def right: Expression = format
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(DateType, StringType)
    +  override def dataType: DataType = DateType
    +
    +  override def nullSafeEval(d: Any, fmt: Any): Any = {
    +    val minItem = DateTimeUtils.getFmt(fmt.asInstanceOf[UTF8String].toUpperCase.toString)
    +    if (minItem == -1) {
    +      // unknown format
    +      null
    +    } else {
    +      val days = d.asInstanceOf[Int]
    +      val year = DateTimeUtils.getYear(days)
    +      if (minItem == Calendar.YEAR) {
    +        days - DateTimeUtils.getDayInYear(days) + 1
    +      } else {
    +        // trunc to MONTH
    +        days - DateTimeUtils.getDayOfMonth(days) + 1
    +      }
    +    }
    +  }
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {
    +    nullSafeCodeGen(ctx, ev, (dateVal, fmt) => {
    +      val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
    +      val form = ctx.freshName("form")
    +      s"""
    +        $form = $dtu.getFmt($fmt);
    --- End diff --
    
    Forgot to add the type for `$form`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message