spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-4751] Dynamic allocation in standa...
Date Wed, 22 Jul 2015 01:58:39 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7532#discussion_r35174850
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -762,6 +789,103 @@ private[master] class Master(
       }
     
       /**
    +   * Handle a request to set the target number of executors for this application.
    +   * @return whether the application has previously registered with this Master.
    +   */
    +  private def handleRequestExecutors(appId: String, requestedTotal: Int): Boolean = {
    +    idToApp.get(appId) match {
    +      case Some(appInfo) =>
    +        logInfo(s"Application $appId requested to set total executors to $requestedTotal.")
    +        appInfo.executorLimit = requestedTotal
    +
    +        // If the application raises the executor limit, then we can launch new executors.
    +        // If there are previously blacklisted workers, then we can launch these new
executors
    +        // by unblacklisting a subset of these workers. For more detail, see `handleKillExecutors`.
    +        if (appInfo.desc.coresPerExecutor.isEmpty) {
    --- End diff --
    
    I think we may not need to execute removeFromBlacklist if the application requests less
resources than what it has been assigned? (it doesn't change the correctness of the program,
since we have this line https://github.com/apache/spark/pull/7532/files#diff-29dffdccd5a7f4c8b496c293e87c8668R598
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message