spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8695][CORE][MLlib] TreeAggregation shou...
Date Tue, 21 Jul 2015 13:26:56 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7397#discussion_r35100773
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1078,7 +1078,9 @@ abstract class RDD[T: ClassTag](
           val scale = math.max(math.ceil(math.pow(numPartitions, 1.0 / depth)).toInt, 2)
           // If creating an extra level doesn't help reduce
           // the wall-clock time, we stop tree aggregation.
    -      while (numPartitions > scale + numPartitions / scale) {
    +
    +      // Don't trigger TreeAggregation when it doesn't save wall-clock time
    +      while (numPartitions > scale + math.ceil((numPartitions).toDouble / scale))
{
    --- End diff --
    
    LGTM except the parens around `(numPartitions)` aren't needed. That's trivial though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message