spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragos <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-4751] Dynamic allocation in standa...
Date Mon, 20 Jul 2015 14:52:42 GMT
Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7532#discussion_r35002754
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala ---
    @@ -43,6 +42,18 @@ private[spark] class ApplicationInfo(
       @transient var endTime: Long = _
       @transient var appSource: ApplicationSource = _
     
    +  // A cap on the number of executors this application can have at any given time.
    +  // By default, this is infinite. Only after the first allocation request is issued
    +  // by the application will this be set to a finite value.
    +  @transient var executorLimit: Int = _
    --- End diff --
    
    You could initialize it here to `Int.MaxValue`. `_` is 0, and the comment is misleading,
since there is no such thing as infinite values for integers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message