spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9067][SQL] Close reader in NewHadoopRDD...
Date Mon, 20 Jul 2015 07:05:34 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7424#discussion_r34971437
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
    @@ -159,7 +164,10 @@ class NewHadoopRDD[K, V](
     
           private def close() {
             try {
    -          reader.close()
    +          if (!finished) {
    --- End diff --
    
    As @srowen mentioned previously, this won't close the `reader` if calling `close` before
reaching at the end of stream. E.g., if there are 10 items in this Iterator, but the user
only uses the first item and then calls `close`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message