spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9026] Refactor SimpleFutureAction.onCom...
Date Mon, 20 Jul 2015 06:55:58 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7385#discussion_r34971118
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/JobWaiter.scala ---
    @@ -50,28 +72,23 @@ private[spark] class JobWaiter[T](
       }
     
       override def taskSucceeded(index: Int, result: Any): Unit = synchronized {
    -    if (_jobFinished) {
    +    if (isCompleted) {
           throw new UnsupportedOperationException("taskSucceeded() called on a finished JobWaiter")
         }
         resultHandler(index, result.asInstanceOf[T])
         finishedTasks += 1
         if (finishedTasks == totalTasks) {
    -      _jobFinished = true
    -      jobResult = JobSucceeded
    -      this.notifyAll()
    +      promise.success()
         }
       }
     
       override def jobFailed(exception: Exception): Unit = synchronized {
    -    _jobFinished = true
    -    jobResult = JobFailed(exception)
    -    this.notifyAll()
    -  }
    -
    -  def awaitResult(): JobResult = synchronized {
    -    while (!_jobFinished) {
    -      this.wait()
    +    // There are certain situations where jobFailed can be called multiple times for
the same
    +    // job. We guard against this by making this method idempotent.
    +    if (!isCompleted) {
    +      promise.failure(exception)
    --- End diff --
    
    Looks `tryFailure` would be simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message