spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8443][SQL] Split GenerateMutableProject...
Date Sun, 19 Jul 2015 01:31:54 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7076#discussion_r34953482
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
    @@ -45,10 +47,41 @@ object GenerateMutableProjection extends CodeGenerator[Seq[Expression],
() => Mu
               else
                 ${ctx.setColumn("mutableRow", e.dataType, i, evaluationCode.primitive)};
             """
    -    }.mkString("\n")
    +    }
    +    // collect projections into blocks as function has 64kb codesize limit in JVM
    +    val projectionBlocks = new ArrayBuffer[String]()
    +    val blockBuilder = new StringBuilder()
    +    for (projection <- projectionCode) {
    +      if (blockBuilder.length > 16 * 1000) {
    +        projectionBlocks.append(blockBuilder.toString())
    +        blockBuilder.clear()
    +      }
    +      blockBuilder.append(projection)
    --- End diff --
    
    Should we insert newlines so that the generated code is slightly more readable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message