spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarutak <>
Subject [GitHub] spark pull request: [SPARK-9052][SparkR] Fix comments after curly ...
Date Fri, 17 Jul 2015 16:35:23 GMT
Github user sarutak commented on a diff in the pull request:
    --- Diff: R/pkg/R/utils.R ---
    @@ -440,19 +446,23 @@ processClosure <- function(node, oldEnv, defVars, checkedFuncs,
newEnv) {
             # Namespaces other than "SparkR" will not be searched.
             if (!isNamespace(func.env) ||
                   (getNamespaceName(func.env) == "SparkR" &&
    -              !(nodeChar %in% getNamespaceExports("SparkR")))) {  # Only include SparkR
    +              !(nodeChar %in% getNamespaceExports("SparkR")))) {
    --- End diff --
    Ah, right. The `nodechar` check is still in the proper place. How about `(getNamespaceName`?
Should it be aligned with `!isNamespace` ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message