spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5681][Streaming] Move 'stopReceivers' t...
Date Fri, 17 Jul 2015 07:41:42 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6294#discussion_r34868282
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
    @@ -220,20 +266,33 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch:
Boolean = false
     
         override def receiveAndReply(context: RpcCallContext): PartialFunction[Any, Unit]
= {
           case RegisterReceiver(streamId, typ, host, receiverEndpoint) =>
    -        registerReceiver(streamId, typ, host, receiverEndpoint, context.sender.address)
    -        context.reply(true)
    +        val successful =
    +          registerReceiver(streamId, typ, host, receiverEndpoint, context.sender.address)
    +        context.reply(successful)
           case AddBlock(receivedBlockInfo) =>
             context.reply(addBlock(receivedBlockInfo))
           case DeregisterReceiver(streamId, message, error) =>
             deregisterReceiver(streamId, message, error)
             context.reply(true)
    +      case StopAllReceivers =>
    +        assert(isTrackerStopping || isTrackerStopped)
    +        stopReceivers()
    +        context.reply(true)
    +    }
    +
    +    /** Stops the receivers. */
    --- End diff --
    
    nit: please update this to "Send stop signal to the receivers"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message