spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8199][SPARK-8184][SPARK-8183][SPARK-818...
Date Fri, 17 Jul 2015 04:55:08 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6981#discussion_r34862222
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
    @@ -54,3 +60,367 @@ case class CurrentTimestamp() extends LeafExpression {
         System.currentTimeMillis() * 1000L
       }
     }
    +
    +case class Hour(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
{
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override protected def nullSafeEval(timestamp: Any): Any = {
    +    val time = timestamp.asInstanceOf[Long] / 1000
    +    val longTime: Long = time.asInstanceOf[Long] + TimeZone.getDefault.getOffset(time)
    +    ((longTime / (1000 * 3600)) % 24).toInt
    +  }
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {
    +    val tz = classOf[TimeZone].getName
    +    defineCodeGen(ctx, ev, (c) =>
    +      s"""(int) ((($c / 1000) + $tz.getDefault().getOffset($c / 1000))
    +                     / (1000 * 3600) % 24)""".stripMargin
    +    )
    +  }
    +}
    +
    +case class Minute(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
{
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override protected def nullSafeEval(timestamp: Any): Any = {
    +    val time = timestamp.asInstanceOf[Long] / 1000
    +    val longTime: Long = time.asInstanceOf[Long] + TimeZone.getDefault.getOffset(time)
    +    ((longTime / (1000 * 60)) % 60).toInt
    +  }
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {
    +    val tz = classOf[TimeZone].getName
    +    defineCodeGen(ctx, ev, (c) =>
    +      s"""(int) ((($c / 1000) + $tz.getDefault().getOffset($c / 1000))
    +                     / (1000 * 60) % 60)""".stripMargin
    +    )
    +  }
    +}
    +
    +case class Second(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
{
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override protected def nullSafeEval(time: Any): Any = {
    +    (time.asInstanceOf[Long] / 1000L / 1000L % 60L).toInt
    +  }
    +
    +  override protected def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String
= {
    +    nullSafeCodeGen(ctx, ev, (time) => {
    +      s"""${ev.primitive} = (int) ($time / 1000L / 1000L % 60L);"""
    +    })
    +  }
    +}
    +
    +abstract class DateFormatExpression extends UnaryExpression with ImplicitCastInputTypes
{
    --- End diff --
    
    need to add a bit comment to explain what this base class is for


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message