spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarutak <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9093][SparkR] Fix single-quotes strings...
Date Thu, 16 Jul 2015 16:16:40 GMT
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7439#discussion_r34806412
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1375,8 +1375,8 @@ setMethod("saveDF",
     #' saveAsTable(df, "myfile")
     #' }
     setMethod("saveAsTable",
    -          signature(df = "DataFrame", tableName = 'character', source = 'character',
    -                    mode = 'character'),
    +          signature(df = "DataFrame", tableName = "character", source = "character",
    +                    mode = "character"),
               function(df, tableName, source = NULL, mode="append", ...){
    --- End diff --
    
    Should we insert a white space into both sides of `=` ?
    Could you fix this as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message