spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...
Date Thu, 16 Jul 2015 05:49:05 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7434#discussion_r34757450
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
    @@ -277,15 +276,21 @@ abstract class LogicalPlan extends QueryPlan[LogicalPlan] with Logging
{
     /**
      * A logical plan node with no children.
      */
    -abstract class LeafNode extends LogicalPlan with trees.LeafNode[LogicalPlan] {
    +abstract class LeafNode extends LogicalPlan {
       self: Product =>
    +
    +  override def children: Seq[LogicalPlan] = Nil
     }
     
     /**
      * A logical plan node with single child.
      */
    -abstract class UnaryNode extends LogicalPlan with trees.UnaryNode[LogicalPlan] {
    +abstract class UnaryNode extends LogicalPlan {
       self: Product =>
    --- End diff --
    
    remove `self: Product =>`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message