spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...
Date Thu, 16 Jul 2015 05:44:07 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7434#discussion_r34757259
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
    @@ -40,13 +40,14 @@ import org.apache.spark.sql.types._
      * requested.  The attributes produced by this function will be automatically copied
anytime rules
      * result in changes to the Generator or its children.
      */
    -abstract class Generator extends Expression {
    -  self: Product =>
    +trait Generator extends Expression { self: Product =>
    --- End diff --
    
    how about:
    ```scala
    trait Generator {
      self: Expression =>
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message