spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8774] [ML] Add R model formula with bas...
Date Tue, 14 Jul 2015 23:41:06 GMT
Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7381#discussion_r34632827
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
    @@ -116,7 +116,7 @@ class VectorAssembler(override val uid: String)
         if (schema.fieldNames.contains(outputColName)) {
           throw new IllegalArgumentException(s"Output column $outputColName already exists.")
         }
    -    StructType(schema.fields :+ new StructField(outputColName, new VectorUDT, false))
    +    StructType(schema.fields :+ new StructField(outputColName, new VectorUDT, true))
    --- End diff --
    
    I noticed that the schema of transform() has it as nullable, so probably transformSchema()
should also. One alternative is to make transform() mark the vector as non-null, but I am
not exactly sure how to do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message