spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6851] [SQL] function least/greatest fol...
Date Tue, 14 Jul 2015 07:01:27 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7387#discussion_r34541982
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
    @@ -311,7 +311,11 @@ case class CaseKeyWhen(key: Expression, branches: Seq[Expression])
extends CaseW
       }
     }
     
    -case class Least(children: Expression*) extends Expression {
    +/**
    + * A function that returns the least value of all parameters.
    --- End diff --
    
    i think it's also important to explicitly say that "least value of all parameters, skipping
null values".



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message