spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8972][SQL]Incorrect result for rollup
Date Mon, 13 Jul 2015 05:34:42 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7343#discussion_r34434356
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -193,16 +193,44 @@ class Analyzer(
         }
     
         def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +      case a if !a.childrenResolved => a // be sure all of the children are resolved.
           case a: Cube =>
             GroupingSets(bitmasks(a), a.groupByExprs, a.child, a.aggregations)
           case a: Rollup =>
             GroupingSets(bitmasks(a), a.groupByExprs, a.child, a.aggregations)
           case x: GroupingSets =>
             val gid = AttributeReference(VirtualColumn.groupingIdName, IntegerType, false)()
    +
    --- End diff --
    
    Oh, ok, I will add more doc there, sorry for the confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message