spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8706] [PySpark] [Project infra] Add pyl...
Date Fri, 10 Jul 2015 21:45:28 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7241#discussion_r34399209
  
    --- Diff: dev/lint-python ---
    @@ -47,11 +49,36 @@ if [ ! -e "$PEP8_SCRIPT_PATH" ]; then
         fi
     fi
     
    +# Easy install pylint in /dev/pylint. To easy_install into a directory, the PYTHONPATH
should
    +# be set to the directory.
    +# dev/pylint should be appended to the PATH variable as well.
    +# Jenkins by default installs the pylint3 version, so for now this just checks the code
quality
    +# of python3.
    +export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
    --- End diff --
    
    AFAIK the PEP8 script currently suffers from this problem as well.  I'm talking with Shane
about configuring some per-build space which lives outside of the work directory that's cleaned
by `git clean` (I want to use these for holding separate `.ivy2` caches for each PRB workspace).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message