spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8199][SPARK-8184][SPARK-8183][SPARK-818...
Date Fri, 10 Jul 2015 16:04:58 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6981#discussion_r34369212
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
    @@ -54,3 +60,341 @@ case class CurrentTimestamp() extends LeafExpression {
         System.currentTimeMillis() * 1000L
       }
     }
    +
    +/**
    + * Abstract class for create time format expressions.
    + */
    +abstract class TimeFormatExpression extends UnaryExpression with ExpectsInputTypes {
    +  self: Product =>
    +
    +  protected val factorToMilli: Int
    +
    +  protected val cntPerInterval: Int
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override protected def nullSafeEval(timestamp: Any): Any = {
    +    val time = timestamp.asInstanceOf[Long] / 1000
    +    val longTime: Long = time + TimeZone.getDefault.getOffset(time)
    +    ((longTime / factorToMilli) % cntPerInterval).toInt
    +  }
    +
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {
    +    val tz = classOf[TimeZone].getName
    +    defineCodeGen(ctx, ev, (c) =>
    +      s"""(${ctx.javaType(dataType)})
    +            ((($c / 1000) + $tz.getDefault().getOffset($c / 1000))
    +                / $factorToMilli % $cntPerInterval)"""
    +    )
    +  }
    +}
    +
    +case class Hour(child: Expression) extends TimeFormatExpression {
    +
    +  override protected val factorToMilli: Int = 1000 * 3600
    +
    +  override protected val cntPerInterval: Int = 24
    +}
    +
    +case class Minute(child: Expression) extends TimeFormatExpression {
    +
    +  override protected val factorToMilli: Int = 1000 * 60
    +
    +  override protected val cntPerInterval: Int = 60
    +}
    +
    +case class Second(child: Expression) extends UnaryExpression with ExpectsInputTypes {
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override protected def nullSafeEval(time: Any): Any = {
    +    time.asInstanceOf[Long] / 1000L / 1000L % 60L
    --- End diff --
    
    This will return Long, but should be Int


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message