spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nssalian <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8743] [Streaming]: Deregister Codahale ...
Date Fri, 10 Jul 2015 04:35:52 GMT
Github user nssalian commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7250#discussion_r34327159
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -581,6 +579,9 @@ class StreamingContext private[streaming] (
           case INITIALIZED =>
             startSite.set(DStream.getCreationSite())
             sparkContext.setCallSite(startSite.get)
    +        // Registering Streaming Metrics at the start of the StreamingContext
    +        assert(env.metricsSystem != null)
    +        env.metricsSystem.registerSource(streamingSource)
             StreamingContext.ACTIVATION_LOCK.synchronized {
    --- End diff --
    
    Changed in the latest commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message