spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarekauel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8199][SPARK-8184][SPARK-8183][SPARK-818...
Date Fri, 10 Jul 2015 00:37:21 GMT
Github user tarekauel commented on the pull request:

    https://github.com/apache/spark/pull/6981#issuecomment-120183532
  
    First of all, thanks for your feedback! `Timestamp` was the proposed datatype in the design
document, that Reynold published on Jira (https://issues.apache.org/jira/browse/SPARK-8864).

    
    I think in order to decide, if we should use `DateType` or `TimestampType`, we have to
think about the usage. If the users will call these methods with `Date` objects, it's unnecessary
to throw the information about the timezone away and `DateType` would be much better. But
I thought that we do the calculation by approximation in order to avoid creating a date object,
e.g. if someone calls these methods using `Timestamp` or `long`.
    
    For `Date` and `Week` it's true, we should definitely switch to `Date`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message