spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8280][SPARK-8281][SQL]Handle NaN, null ...
Date Thu, 09 Jul 2015 06:22:16 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6835#discussion_r34226508
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
    @@ -259,19 +285,14 @@ case class Atan2(left: Expression, right: Expression)
             null
           } else {
             // With codegen, the values returned by -0.0 and 0.0 are different. Handled with
+0.0
    -        val result = math.atan2(evalE1.asInstanceOf[Double] + 0.0,
    +        math.atan2(evalE1.asInstanceOf[Double] + 0.0,
    --- End diff --
    
    i don't think u need to wrap here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message