spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8764][ML] string indexer should take op...
Date Wed, 08 Jul 2015 23:14:19 GMT
Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7266#discussion_r34209405
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -65,12 +66,15 @@ class StringIndexer(override val uid: String) extends Estimator[StringIndexerMod
       def this() = this(Identifiable.randomUID("strIdx"))
     
       /** @group setParam */
    +  def setSkipInvalid(value: Boolean): this.type = set(skipInvalid, value)
    --- End diff --
    
    Do you have a specific example in mind?
    
    My suggestion was because `SkipInvalid` has nothing to do with the fitting routine itself;
rather, it affects how the model is evaluated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message