spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8538][SPARK-8539][ML] Linear Regression...
Date Tue, 07 Jul 2015 18:30:06 GMT
Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7099#discussion_r34073475
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -194,10 +203,15 @@ class LinearRegression(override val uid: String)
         if (handlePersistence) instances.unpersist()
     
         // TODO: Converts to sparse format based on the storage, but may base on the scoring
speed.
    -    copyValues(new LinearRegressionModel(uid, weights.compressed, intercept))
    +    val model = new LinearRegressionModel(uid, weights.compressed, intercept)
    +    val trainingResults = new LinearRegressionTrainingResults(
    +      model.transform(dataset).select(model.getPredictionCol, model.getLabelCol),
    +      lossHistory.result())
    --- End diff --
    
    Okay. I will leave as is and document that LossHistory is for debugging purposes and not
actual negative log likelihood


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message