spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8819] Fix build for maven 3.3.x
Date Mon, 06 Jul 2015 18:42:31 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/7219#issuecomment-118953448
  
    >  the underlying issue here is that having test-jar dependencies screws up the maven
shade plugin
    
    But my suggestion does not add a "test-jar" dependency. You'd have a proper module, providing
SparkFunSuite, just that it's separate from spark-core. It's just a dependency like any other,
that happens to provide test code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message