spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8819] Fix build for maven 3.3.x
Date Mon, 06 Jul 2015 17:51:49 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/7219#issuecomment-118938007
  
    Hi guys,
    
    I haven't had the chance to distill the discussion and the changes yet, but I have a suggestion.
    
    What about moving `SparkFunSuite` to a separate module? That module can depend on scalatest,
and it's added to all other modules as a test-scope dependency.
    
    It's not optimal, but I kinda like it better than the more intrusive approach that seems
to have been chosen here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message