spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8657] [YARN] Fail to upload conf archiv...
Date Mon, 06 Jul 2015 14:18:08 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7055#discussion_r33937908
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -912,7 +943,10 @@ object Client extends Logging {
       val ENV_DIST_CLASSPATH = "SPARK_DIST_CLASSPATH"
     
       // Subdirectory where the user's hadoop config files will be placed.
    -  val LOCALIZED_HADOOP_CONF_DIR = "__hadoop_conf__"
    +  val LOCALIZED_CONF_DIR = "__hadoop_conf__"
    --- End diff --
    
    why did you change the name of this?  please revert as previous name was more descriptive
and the change is unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message