spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragos <...@git.apache.org>
Subject [GitHub] spark pull request: [MESOS][SPARK-8798] Allow additional uris to b...
Date Mon, 06 Jul 2015 10:35:55 GMT
Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7195#discussion_r33922508
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
---
    @@ -124,6 +124,13 @@ private[spark] class MesosSchedulerBackend(
             Value.Scalar.newBuilder()
               .setValue(MemoryUtils.calculateTotalMemory(sc)).build())
           .build()
    +
    +    sc.conf.getOption("spark.mesos.uris").map { uris =>
    +      uris.split(",").foreach { uri =>
    +        command.addUris(CommandInfo.URI.newBuilder().setValue(uri.trim()))
    +      }
    +    }
    --- End diff --
    
    There's a common superclass of all these three classes called `MesosSchedulerUtils`. I
think this code could go there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message